Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.3.0 #177

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Release v1.3.0 #177

merged 2 commits into from
Oct 19, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Oct 19, 2023 •
edited
Loading

Pre-release operations:

  • Version bumping
  • Citation updates
  • Modules updates

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f1643ce

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-19 14:46:11

@pinin4fjords pinin4fjords added this to the 1.3.0 milestone Oct 19, 2023
jonasscheid
jonasscheid approved these changes Oct 19, 2023
View reviewed changes
Copy link

@jonasscheid jonasscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Adjust spacing of version in nextflow.config

else, LGTM 👍🏼 !

nextflow.config Outdated Show resolved Hide resolved
edmundmiller
edmundmiller approved these changes Oct 19, 2023
View reviewed changes
Copy link

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides @jonasscheid's nit

@pinin4fjords
Copy link
Member Author

Thanks @jonasscheid @emiller88 !

@pinin4fjords pinin4fjords merged commit 55a6b85 into nf-core:dev Oct 19, 2023
14 checks passed
@pinin4fjords pinin4fjords deleted the release_v1.3.0 branch October 19, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

@jonasscheid jonasscheid jonasscheid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pinin4fjords @edmundmiller @jonasscheid